ytsaurus / ytsaurus/ytsaurus

Enable logging anchor profiling by default

Open
#868 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.2k
Forks
220
PR merge metrics
No merged PRs in 30d

Description

Re recent discussion in SIG MapReduce.

It would be really good to have the following option enable by default: https://github.com/ytsaurus/ytsaurus/blob/f781206ea03e38a6d777252c0de2e7ff51740a93/yt/yt/core/logging/config.cpp#L208-L209

It is often useful in situations when troubles are already happening, and you can see it in logs of individual components, but the corresponding profiling metric is not added to the code, so you cannot perceive the state of a cluster at scale.

I suggest turning it on by default, considering that it should not cost much on clusters of small-medium sizes (up to thousands of nodes), and the value of having it enabled as everywhere as possible is much higher than the inconvenience of one-time opting it out for the high-cardinality components (or, alternatively, tuning thresholds for them).

Contributor guide

Open the contributing guide

Research direction

Open yt/yt/core/logging/config.cpp at lines 208-209 and inspect the option linked in the issue. Confirm how its default is defined and what existing checks cover it; done means logging anchor profiling is enabled by default while retaining the documented ability to opt out or tune thresholds for high-cardinality components.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
observability-sre
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.