yt-project / yt-project/libyt

Annotate Clumps Not Working in Odd MPI Size

Open
#39 0 comments 0 reactions 1 assignee View on GitHub

@cindytsai is already working on this.

Since Nov 11, 2021.

enhancement toolkit
Dominant language
C++
Stars
23
Forks
7
PR merge metrics
No merged PRs in 30d

Description

Annotate Clumps Not Working in Odd MPI Size

  • Test Problem: gamer MHD Vortex
  • Inline Script:
    import numpy as np
    import yt
    from yt.data_objects.level_sets.api import Clump, find_clumps
    yt.enable_parallelism()
    def yt_inline():
        ds = yt.frontends.libyt.libytDataset()
        data_source = ds.all_data()
    
        c_min = 10 ** np.floor(np.log10(data_source[("gas", "density")]).min())
        c_max = 10 ** np.floor(np.log10(data_source[("gas", "density")]).max() + 1)
    
        master_clump = Clump(data_source, ("gas", "density"))
        master_clump.add_validator("min_cells", 20)
    
        find_clumps(master_clump, c_min, c_max, 2.0)
        leaf_clumps = master_clump.leaves
    
        prj = yt.ProjectionPlot(ds, "z", ("gamer","Dens"), center="c")
        prj.annotate_clumps(leaf_clumps)
    
        # Either having this is clause or not, it will still failed when MPI = 3.
        if yt.is_root():
            prj.save()
    
  • Description:
    • FAILED in MPI = 3, stuck at somewhere else, other than class IOHandlerlibyt.
    • SUCCEED in MPI = 1, and MPI = 4.
      • Just like the projection plot, because i didn't set a range that actually grab a clump.
        Fig000000001_Projection_z_Dens

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.