yonaskolb / yonaskolb/XcodeGen
Trailing slash in path can cause file not to be included
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 8.8k
- Forks
- 908
- Avg merge
- 17d 14h
- Merged PRs (30d)
- 2
Description
Having a trailing / in the path will files not to be added to the project file.
This doesn't work
- path: ../Pods/GTMSessionFetcher/Source/
includes:
- "GTMSessionFetcher.[hm]"
- "GTMSessionFetcherLogging.[hm]"
- "GTMSessionFetcherService.[hm]"
- "GTMSessionUploadFetcher.[hm]"
- "GTMGatherInputStream.[hm]"
- "GTMMIMEDocument.[hm]"
- "GTMReadMonitorInputStream.[hm]"
This will work
- path: ../Pods/GTMSessionFetcher/Source/
includes:
- "**/GTMSessionFetcher.[hm]"
- "**/GTMSessionFetcherLogging.[hm]"
- "**/GTMSessionFetcherService.[hm]"
- "**/GTMSessionUploadFetcher.[hm]"
- "**/GTMGatherInputStream.[hm]"
- "**/GTMMIMEDocument.[hm]"
- "**/GTMReadMonitorInputStream.[hm]"
And this will work
- path: ../Pods/GTMSessionFetcher/Source
includes:
- "GTMSessionFetcher.[hm]"
- "GTMSessionFetcherLogging.[hm]"
- "GTMSessionFetcherService.[hm]"
- "GTMSessionUploadFetcher.[hm]"
- "GTMGatherInputStream.[hm]"
- "GTMMIMEDocument.[hm]"
- "GTMReadMonitorInputStream.[hm]"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Use the configuration examples in the issue to reproduce the difference between a trailing-slash path and the same path without the slash. Locate the path and include-matching entry point, then verify that the listed files are included in the generated project for both forms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift, yaml
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100