yonaskolb / yonaskolb/XcodeGen

Dependency to legacy target

Open
#286 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Swift
Stars
8.8k
Forks
908
Avg merge
17d 14h
Merged PRs (30d)
2

Description

Just playing around with dependencies and noticed when a target has a dependency to a legacy target then XcodeGen adds the legacy target into the Copy Bundle Resources build phase resulting in build error.

Consider the following snippet:

targets:
  MyTarget:
    dependencies:
      - target: Legacy
        embed: false
  Legacy:
    type: ""

without explicit embed: false as seen above Legacy target is added into the Copy Bundle Resources build phase of MyTarget

Maybe embed value as true as default for legacy dependencies would be a better option?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the YAML target snippet and generate the Xcode project. Inspect MyTarget’s Copy Bundle Resources build phase and the handling of its dependency on the legacy target. Done when the default behavior no longer causes Legacy to be added there, while the explicit embed: false case remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
build-system, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.