Mark `SkipOnEmptyTrait::$skipOnEmpty` as readonly
Open
Nobody has claimed this yet.
status:under discussion
- Dominant language
- PHP
- Stars
- 167
- Forks
- 47
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 3
Description
This allow to create custom rules as readonly classes.
PS This is major change.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for SkipOnEmptyTrait and its $skipOnEmpty property, then inspect related tests and usages before changing it. Confirm that custom rules can be declared as readonly classes and that the existing validation behavior remains covered; account for the issue's warning that this is a major change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100