yiisoft / yiisoft/validator

Adjust messages to be more human friendly

Open
#603 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

severity:BC breaking type:enhancement
Dominant language
PHP
Stars
167
Forks
47
Avg merge
1d 19h
Merged PRs (30d)
3

Description

Rule Current messaage Proposed message
Required Value not passed Value is required
In This value is not in the list of acceptable values. Acceptable values are: "1", "2", "3".

TODO: review more messages

  1. Do not use "not"
  2. Specify what value is valid rather than reporting that current one isn't

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the message definitions in src/Rule/Required.php and src/Rule/In.php, then review the other validation rule messages in the repository. Update messages to avoid “not” where appropriate and state valid values, using the proposed wording as a guide; done means the reviewed messages follow the listed guidelines.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.