yiisoft / yiisoft/translator

Add support for `number` format in `SimpleMessageFormatter` (`intl` polyfill)

Open
#68 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status:under discussion type:enhancement
Dominant language
PHP
Stars
26
Forks
10
Avg merge
48m
Merged PRs (30d)
1

Description

Is it really needed? In validator in places where it's used it's just a simple substitution of integer numbers. Probably could be useful somewhere else. Then how we go about rounding, etc.?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing SimpleMessageFormatter and the validator locations where integer substitutions are currently used. Determine the intended scope for number formatting, including rounding behavior and whether broader uses are required; the work is done only once that behavior is agreed and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
internationalization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.