yiisoft / yiisoft/proxy-middleware
`TrustedHostsNetworkResolver` - add `by` support
Open
Nobody has claimed this yet.
status:under discussion
type:enhancement
- Dominant language
- PHP
- Stars
- 8
- Forks
- 2
- Avg merge
- 17h 16m
- Merged PRs (30d)
- 3
Description
In process(), here :
$actualHost = $request->getServerParams()['REMOTE_ADDR'] ?? null;
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in TrustedHostsNetworkResolver::process(), at the REMOTE_ADDR lookup shown in the issue. First determine what “by” support means from the repository’s existing resolver conventions, then identify the relevant tests or entry points. Done means the intended “by” behavior is implemented and covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100