yiisoft / yiisoft/mailer

Add phpdoc to MessageInterface::getHeaders(), consider not using null

Open
#112 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type:docs
Dominant language
PHP
Stars
44
Forks
13
Avg merge
54m
Merged PRs (30d)
1

Description

Currently, MessageInterface::getHeaders() doesn't have phpdoc. We should add it.

Also, it may return null which means "do not add headers". An empty array could be possibly used for the same purpose. Need to consider it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with MessageInterface::getHeaders() and inspect its current contract and implementations. Add phpdoc describing the return value, then resolve whether null or an empty array represents no headers and ensure the documented behavior matches the interface.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend-api-design, documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.