yiisoft / yiisoft/form

Remove unnecessary methods form "Hidden" field

Open
#373 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

severity:BC breaking
Dominant language
PHP
Stars
47
Forks
18
Avg merge
59m
Merged PRs (30d)
1

Description

Currenty Hidden field extends InputField and contains many unnecessary methods:

  • inputContainerTag()
  • useContainer()
  • template()
  • beforeInput()

But Hidden field must generate only input tag. It needs to refactor and create base class without these methods, but with features of InputField that relate to the input tag .

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the Hidden and InputField classes and the listed methods to identify which behavior is specific to the input tag. Refactor a base class that preserves the relevant InputField features while allowing Hidden to generate only an input tag. Done means Hidden no longer carries the unnecessary container, template, or lifecycle methods and existing behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.