Move `$definitions` to the first place in `Factory::__construct()`
Open
Nobody has claimed this yet.
severity:BC breaking
- Dominant language
- PHP
- Stars
- 36
- Forks
- 14
- Avg merge
- 59m
- Merged PRs (30d)
- 1
Description
This is necessary for consistenc with StrictFactory, where $definitions is required parameter and is in the first place.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Factory::__construct() and compare its parameter order with StrictFactory::__construct(), focusing on the position of $definitions. Check references to Factory construction for compatibility, then confirm that $definitions is the first parameter and existing usage remains valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100