Remove methods replacing query condition
Open
Nobody has claimed this yet.
severity:BC breaking
status:under discussion
type:enhancement
- Dominant language
- PHP
- Stars
- 216
- Forks
- 51
- Avg merge
- 3d 10h
- Merged PRs (30d)
- 2
Description
https://github.com/yiisoft/db/blob/master/src/Query/QueryPartsInterface.php#L642
Methods like where() are often the source of problems cause sometimes these are used instead of andWhere(), orWhere().
Possible solutions:
- Remove such methods. Add reset*() for the rare cases it is needed.
- Make where() the same as andWhere().
Add reset*() for the rare cases it is needed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/Query/QueryPartsInterface.php around line 642 and inspect the where(), andWhere(), and orWhere() methods. Resolve which proposed API direction is intended, including the reset*() behavior; done means the selected method semantics and removals or additions are agreed and reflected in the interface.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100