yiisoft / yiisoft/db

refactor QueryBuilder::buildUnion

Open
#69 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
216
Forks
51
Avg merge
3d 10h
Merged PRs (30d)
2

Description

it should include the process of adding parenthesis to allow simpler override in sqlite\QueryBuilder.
Currently the complete build() method is overridden just to add two parenthesis.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate QueryBuilder::buildUnion and the sqlite\QueryBuilder implementation, then compare how the complete build() method is currently overridden. Refactor the parenthesis handling into buildUnion so the SQLite override can be simpler, while preserving the existing union-query behavior; no test file is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, sql, sqlite
Domain
database
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.