Add check to non-empty pattern in `HttpHeader::withPattern()` method
Open
Nobody has claimed this yet.
status:under discussion
- Dominant language
- PHP
- Stars
- 39
- Forks
- 17
- Avg merge
- 1h 9m
- Merged PRs (30d)
- 1
Description
Do we need to add such a check and throw exception if pattern empty?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the HttpHeader::withPattern() method and inspect how an empty pattern is currently handled. Check existing tests and exception conventions for this component, then clarify the expected exception behavior and add coverage showing what should happen for an empty pattern.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100