yiisoft / yiisoft/active-record
Hide service methods
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 119
- Forks
- 38
- Avg merge
- 1h 11m
- Merged PRs (30d)
- 1
Description
Make them private / protected or hide behind a proxy like $model->activeRecord()->propertyNames() (see https://github.com/yiisoft/active-record/issues/388)
ActiveRecordInterface::
propertyNames()propertyValues()oldValue()primaryKeyOldValue()primaryKeyOldValues()tableSchema()relatedRecords()?hasMany()hasOne()resetRelation()oldValues()newValues()?assignOldValue()assignOldValues()
ActiveQueryInterface::getTablesUsedInFrom() and QueryInterface::getTablesUsedInFrom()
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the listed methods in ActiveRecordInterface, then compare ActiveQueryInterface::getTablesUsedInFrom() and QueryInterface::getTablesUsedInFrom(), with issue #388 as context. Define which methods should become private or protected and which should be exposed through a proxy; done means the agreed service methods are no longer part of the public interfaces without breaking intended usage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100