yiisoft / yiisoft/active-record

refactor joinWith() storing and processing

Open
#52 7 comments 0 reactions 1 assignee View on GitHub

@cebe is already working on this.

Since Nov 25, 2015.

Dominant language
PHP
Stars
119
Forks
38
Avg merge
1h 11m
Merged PRs (30d)
1

Description

refactor joinWith internals:

  • store one join in $joinWith property instead of the whole array. i.e. normalize beforehand!
  • makes a lot of the aliasing much cleaner and simpler.

related to #10253

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.