yiisoft / yiisoft/active-record

`ActiveQuery` class should not extend `Yiisoft\Db\Query\Query`

Open
#281 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type:enhancement
Dominant language
PHP
Stars
119
Forks
38
Avg merge
1h 11m
Merged PRs (30d)
1

Description

Yiisoft\Db\Query\Query class can be extended in each supported DBMS.

E.g. we can have Yiisoft\Db\Mssql\Query which extends Yiisoft\Db\Query\Query.

In this case ActiveQuery will not know about the extensions in Yiisoft\Db\Mssql\Query.

Suggestion

Connection of DBMS should return concrete Query instance to use it in ActiveQuery.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how ActiveQuery receives its query object from Connection, then inspect the Query abstraction and the supported DBMS extensions described in the issue. The work is done when ActiveQuery uses the concrete DBMS Query instance returned by Connection without losing extension-specific behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
database
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.