yewstack / yewstack/yew

Make yew's #[derive(..)] macros re-exportable.

Open
#1,454 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-yew-macro feature-request
Dominant language
Rust
Stars
32.8k
Forks
1.5k
Avg merge
5h 34m
Merged PRs (30d)
2

Description

Describe the feature you'd like

Consider the following structure of nested crates common to a project:

project/
 | --- common/
 | --- feature1/
 | --- feature2/

The common crate re-exports yew for feature crates to use

// project/common/src/lib.rs
pub use yew;
# project/common/Cargo.toml
[dependencies]
yew = "0.17.2"

The features crates use yew via the common crate:

// project/feature1/src/lib.rs
use common::yew::prelude::*;

#[derive(Properties, Clone)]
pub struct Props;
# project/feature1/Cargo.toml
[dependencies]
common = {path="../common"}

Current behavior:
The re-exported derive macros (#[derive(Properties)]) don't work, unless the feature crates explicitly include yew in their respective Cargo.toml

14 | #[derive(Properties, Clone)]
   |          ^^^^^^^^^^ could not find `yew` in `{{root}}`

Additional Context

I encoutered the same behavior of re-exporting not working with serde::{Deserialize, Serialize} (https://github.com/serde-rs/serde/issues/1465)

From discord chat

Simon: This doesn't work because the generated code needs to use members of the Yew crate. There's no way around that...
Teymour: It would be technically possible to get around this, but probably not worth it.
Simon: This could only work if you could somehow rewrite the generated code to depend on mindwiki_core::yew instead of yew
Teymour: We could use a compile-time environment variable to optionally set a custom prefix to use instead of yew but it seems like a lot of extra cruft to introduce.
Simon I'm like 99% sure this would violate at least 3 invariants xD
Pragy: @siku2 won't that be possible by doing crate::?
Simon: It might work but Span::mixed_site has only just hit stable in 1.45 so we aren't using it yet. If you open an issue for this I will look into it some more

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the nested-crate example using common/src/lib.rs and feature1/src/lib.rs, then reproduce the #[derive(Properties)] failure with the shown Cargo.toml dependencies. Read the derive-macro implementation and existing macro tests, if present; done means the re-exported yew macros compile without adding yew directly to each feature crate.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.