yesodweb / yesodweb/persistent

`Primary` doesn't trigger migrations as it should

Open
#906 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Haskell
Stars
486
Forks
306
PR merge metrics
No merged PRs in 30d

Description

  • Removing a Primary declaration does not cause the uniqueness constraint or primary key to be dropped

    <<<
    User
      name Text
      Primary name
    ====
    User
      name Text
    >>>
    

    This should result in a migration that drops the primary key. It does not.

  • Adding a Primary declaration to an existing non-unique column isn't considered an unsafe migration by any of the current backends. It fails on sqlite at runtime.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how migration changes for Primary declarations are generated and how unsafe migrations are checked across the current backends. Reproduce both examples, including the SQLite case, and inspect the generated migration and safety result. Done means removing Primary drops the primary key or uniqueness constraint, while adding it to a non-unique column is reported as unsafe.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.