yesodweb / yesodweb/persistent

persistent-redis-2.13.0.2 fails to build with hedis-0.16.1

Open
#1,631 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
486
Forks
306
PR merge metrics
No merged PRs in 30d

Description

For stackage nightly:

       Building library for persistent-redis-2.13.0.2...                                               
       [1 of 7] Compiling Database.Persist.Redis.Config                                                                                                                                                                                                                 
       [2 of 7] Compiling Database.Persist.Redis.Exception                                                                                                                                                                                                              
       [3 of 7] Compiling Database.Persist.Redis.Parser         
       /home/curators/work/unpack-dir/unpacked/persistent-redis-2.13.0.2-a7bc04b4f36b9974663b3db1e1a0e0f273206a4ca21a8ae378209bd48f5c15ed/Database/Persist/Redis/Config.hs:36:18: error: [GHC-76037]                                                                    
           Not in scope: type constructor or class ‘R.PortID’                                                                       
           Note: The module ‘Database.Redis’ does not export ‘PortID’.                                             
          |                                                       
       36 |     rdPort    :: R.PortID, -- ^ Port                                                                                                                                                                                                                        
          |                  ^^^^^^^^                             

       /home/curators/work/unpack-dir/unpacked/persistent-redis-2.13.0.2-a7bc04b4f36b9974663b3db1e1a0e0f273206a4ca21a8ae378209bd48f5c15ed/Database/Persist/Redis/Config.hs:70:48: error: [GHC-76037]                                                                    
           Not in scope: ‘R.connectHost’                          
           Note: The module ‘Database.Redis’ does not export ‘connectHost’.                                                         
           Suggested fix:                                         
             Perhaps use record field of ConnInfo ‘R.connectHooks’ (imported from Database.Redis)
          |                                                       
       70 |         host               <- o .:? "host" .!= R.connectHost R.defaultConnectInfo
          |                                                ^^^^^^^^^^^^^                                                            

       /home/curators/work/unpack-dir/unpacked/persistent-redis-2.13.0.2-a7bc04b4f36b9974663b3db1e1a0e0f273206a4ca21a8ae378209bd48f5c15ed/Database/Persist/Redis/Config.hs:71:48: error: [GHC-76037]                                                                    
           Not in scope: ‘R.connectPort’                          
           Note: The module ‘Database.Redis’ does not export ‘connectPort’.                                                         
          |                                                       
       71 |         port               <- o .:? "port" .!= R.connectPort R.defaultConnectInfo
          |                                                ^^^^^^^^^^^^^                                                            

       /home/curators/work/unpack-dir/unpacked/persistent-redis-2.13.0.2-a7bc04b4f36b9974663b3db1e1a0e0f273206a4ca21a8ae378209bd48f5c15ed/Database/Persist/Redis/Config.hs:87:13: error: [GHC-22385]                                                                    
           Not in scope: record field ‘R.connectHost’
           Note: The module ‘Database.Redis’ does not export ‘connectHost’.                                                         
           Suggested fix:                                         
             Perhaps use record field of ConnInfo ‘R.connectHooks’ (imported from Database.Redis)
          |                                                       
       87 |             R.connectHost = unpack h,
          |             ^^^^^^^^^^^^^            

https://github.com/commercialhaskell/stackage/issues/8017

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in Database/Persist/Redis/Config.hs, where the build errors reference R.PortID, R.connectHost, and R.connectPort. Compare these uses with the hedis-0.16.1 Database.Redis API and update the configuration code for the exported interface. Done means persistent-redis builds successfully against hedis-0.16.1 without the reported scope errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell, redis
Domain
build-system, database
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.