yesodweb / yesodweb/persistent

`PersistField Int` should parse `PersistRational`

Open
#1,527 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
486
Forks
306
PR merge metrics
No merged PRs in 30d

Description

The instance PersistField Int does not work with the Postgres numeric type, which shows up repeatedly for the esqueleto library.

Link to code.

We should really probably just make PersistRational work.

https://github.com/bitemyapp/esqueleto/issues/82
https://github.com/bitemyapp/esqueleto/issues/54
https://github.com/bitemyapp/esqueleto/issues/175

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read persistent/Database/Persist/Class/PersistField.hs around lines 136-140, then trace the existing PersistField Int parsing path. Reproduce the Postgres numeric case described in the issue and use the linked esqueleto reports as acceptance context; done means Int values backed by numeric parse without breaking existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell, postgresql
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.