yesodweb / yesodweb/persistent

Strict fields on `PersistValue`

Open
#1,443 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
486
Forks
306
PR merge metrics
No merged PRs in 30d

Description

Related to #1440 - it's probably good for the fields on PersistValue to be strict. This would simplify the NFData instance and reduce the need for extra passes over lists.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the PersistValue definition and its NFData instance, then read the context in related issue #1440. Confirm which fields should be strict and identify the list traversals or extra passes affected. Done means the fields are strict and the NFData implementation is simplified without changing PersistValue behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
databases
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.