yesodweb / yesodweb/persistent
Please export `EntityDef`, `UnboundEntityDef`, `unbindEntityDef`, `embedEntityDefs`, `connEscapeRawName` because serversession new version use it.
Nobody has claimed this yet.
- Dominant language
- Haskell
- Stars
- 486
- Forks
- 306
- PR merge metrics
- No merged PRs in 30d
Description
I was working on making a module called serversession compatible with the new persistent.
updated: LTS: 19 by ncaq · Pull Request #27 · yesodweb/serversession
I believe this is mostly implemented and all that is left is to test the behavior, merge and release.
However, I am concerned that I imported some persistent internal modules during the implementation.
I think I had to import some Internal modules when I implemented it.
If the imports are avoidable in this content diff, I would be glad to know that.
If this import is essentially necessary, I hope you will consider doing an export.
List of Internal elements.
EntityDefUnboundEntityDef,unbindEntityDefembedEntityDefsconnEscapeRawName
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing serversession Pull Request #27 and the Internal imports it introduces for EntityDef, UnboundEntityDef, unbindEntityDef, embedEntityDefs, and connEscapeRawName. Compare those uses with persistent's current exports and determine whether the imports can be avoided. Done means the compatibility work no longer depends on unnecessary internal modules, with behavior tested before the related release.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- haskell
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100