ydb-platform / ydb-platform/ydb

Swap if with comparator to get rid of nothing

Open
#8,564 1 comment 0 reactions 1 assignee View on GitHub

@pavelvelikhov is already working on this.

Since Aug 31, 2024.

  • #7771 by @Tony-Romanov — closed without merging
Dominant language
C++
Stars
4.8k
Forks
820
Avg merge
17h 5m
Merged PRs (30d)
743

Description

Currently ssaProgram doesn't support nulls. And so predicate with Nothing can't be pushed down
But in some cases it's possible to get rid of Nothing by rewriting a predicate

example predicate:
(case when household_demographics.hd_vehicle_count > 0
then household_demographics.hd_dep_count/ household_demographics.hd_vehicle_count
else null
end) > 1.2

it can be rewritten to:
if (household_demographics.hd_vehicle_count > 0, household_demographics.hd_dep_count/ household_demographics.hd_vehicle_count > 1.2, false)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.