yashlamba / yashlamba/handwrite

pngtosvg: Merge thresholding part in pngToBmp to sheettopng.py code to accommodate variable lighting in inputs

Open
#76 0 comments 0 reactions 1 assignee View on GitHub

@sakshamarora1 is already working on this.

Since Jan 20, 2022.

Dominant language
Python
Stars
543
Forks
52
PR merge metrics
No merged PRs in 30d

Description

Related: #3

We should do this thresholding in sheettopng during the cropping process.

https://github.com/builtree/handwrite/blob/adca270f90e3ac5c3eae31eb1e49e05f3142bcd3/handwrite/pngtosvg.py#L69-L76

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.