xoofx / xoofx/markdig

Add embed-responsive wrapper and classes to media links when using Bootstrap extension

Open
#434 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
5.3k
Forks
510
Avg merge
11d 3h
Merged PRs (30d)
6

Description

Bootstrap provides classes for embeds: https://getbootstrap.com/docs/4.4/utilities/embed/

The Bootstrap extension currently adds img-fluid to media links, because media links are treated as images. Instead, it should add embed-responsive-item. The iframe needs to be surrounded with a div with the following classes: embed-responsive embed-responsive-16by9 (the aspect ratio could be configurable).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Bootstrap extension's handling of media links and its iframe output. Check how media links currently receive the img-fluid class, then define the expected wrapper and item classes from the issue. Done means iframe media uses embed-responsive embed-responsive-16by9, embed-responsive-item replaces img-fluid, and the aspect ratio can be configured.

Written by the indexing model from the issue text.

Assessment

Tech stack
bootstrap, csharp
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.