xoofx / xoofx/markdig

Add support for implicit figures for images

Open
#100 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement PR Welcome!
Dominant language
C#
Stars
5.3k
Forks
510
Avg merge
8d 5h
Merged PRs (30d)
5

Description

I'm using builder.UseFigures() in my pipeline builder code, but I don't see figure output rendered.

Example here:
https://babelmark.github.io/?text=!%5BSave+Image+to+Azure+Blob+Storage+Addin%5D(https%3A%2F%2Fgithub.com%2FRickStrahl%2FSaveToAzureBlob-MarkdownMonster-Addin%2Fraw%2Fmaster%2FSaveToAzureMarkdownMonsterAddin.gif)%0A

Markdig renders the image only which seems like Figures is not doing anything. Pandoc renders with figure classes, multi-markdown uses figure proper figure/figcaption elements.

Looks like MarkDig should render figure/figurecaption, but I don't see it rendered. Double checked to make sure FigureExtension is loaded in the final PipelineBuilder used to render with:

Markdown.Convert(markdown, renderer, Pipeline);

BTW, how does the Markdig Parser run in BabelMark? With all options enabled?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing builder.UseFigures(), FigureExtension, and the Markdown.Convert(markdown, renderer, Pipeline) entry point. Compare Markdig's current image output with the figure and figcaption behavior described for Pandoc and multimarkdown, including the BabelMark example. Done means enabled figures produce the expected figure markup for images.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.