missing CMakeLists option for deep plc
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 3.3k
- Forks
- 808
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
There is no option to set OPUS_DEEP_PLC, and add_sources_group(opus lpcnet ${deep_plc_headers} ${deep_plc_sources}) is defined twice:
if (OPUS_DEEP_PLC OR OPUS_DRED OR OPUS_OSCE)
add_sources_group(opus lpcnet ${deep_plc_headers} ${deep_plc_sources})
set(OPUS_DNN TRUE)
else()
set(OPUS_DNN FALSE)
endif()
if (OPUS_DNN)
add_sources_group(opus lpcnet ${deep_plc_headers} ${deep_plc_sources})
target_compile_definitions(opus PRIVATE ENABLE_DEEP_PLC)
endif()
https://github.com/xiph/opus/blob/main/CMakeLists.txt#L399
The file is missing something like:
set(OPUS_DEEP_PLC_HELP_STR "enable deep plc.")
option(OPUS_DEEP_PLC ${OPUS_DEEP_PLC_HELP_STR} OFF)
add_feature_info(OPUS_DEEP_PLC OPUS_DEEP_PLC ${OPUS_DEEP_PLC_HELP_STR})
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in CMakeLists.txt around line 399 and compare the OPUS_DEEP_PLC configuration with related OPUS_* options. Add the missing option and feature entry, address the duplicated add_sources_group call, and verify that CMake configuration exposes OPUS_DEEP_PLC and reports it correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, cmake
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100