xiph / xiph/opus

return value of opus_dred_parse

Open
#385 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
3.3k
Forks
808
PR merge metrics
No merged PRs in 30d

Description

for encoder i set OPUS_SET_DRED_DURATION to 100,
while decoding stream , i set dred_input with loss frames , but the return value of opus_dred_parse sometimes smaller than dred_input , sometimes larger !!!
i dont no why ?
how can i deal with the return value smaller than input ?

/* Only decode the amount we need to fill in the gap. */
ret = opus_dred_parse(dred_dec, dred, data, len, IMIN(48000, IMAX(0, dred_input)), sampling_rate, &dred_end, 0);
printf("--------dred_input=%d, opus_dred_parse ret = %d\n", dred_input, ret);

log print:
--------dred_input=960, opus_dred_parse ret = 720
--------dred_input=960, opus_dred_parse ret = 720
--------dred_input=960, opus_dred_parse ret = 720
--------dred_input=960, opus_dred_parse ret = 720
--------dred_input=4800, opus_dred_parse ret = 4560
--------dred_input=960, opus_dred_parse ret = 720
--------dred_input=1920, opus_dred_parse ret = 2640

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the opus_dred_parse entry point and reproduce the reported calls using OPUS_SET_DRED_DURATION set to 100 and the logged dred_input values. Compare the return value with the supplied input and sampling rate to establish the API's expected behavior. Done means the differing results are explained and the correct handling or required project change is identified.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.