xiph / xiph/opus

Opus 1.5.x and main compilation failing with GCC 8.5.0

Open
#344 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
3.3k
Forks
808
PR merge metrics
No merged PRs in 30d

Description

Opus 1.5.2 Buils is failing with gcc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-18).

g++ 8.5.0 not compatible with AVX2 interensic.

../silk/x86/NSQ_del_dec_avx2.c: In function 'silk_nsq_del_dec_scale_states_avx2':
../silk/x86/NSQ_del_dec_avx2.c:959:43: warning: implicit declaration of function '_mm_loadu_si64'; did you mean '_mm_loadu_si32'? [-Wimplicit-function-declaration]
__m256i x = _mm256_cvtepi16_epi64(_mm_loadu_si64(&x16[i]));
^~~~~~~~~~~~~~
_mm_loadu_si32
../silk/x86/NSQ_del_dec_avx2.c:959:43: warning: nested extern declaration of '_mm_loadu_si64' [-Wnested-externs]
../silk/x86/NSQ_del_dec_avx2.c:959:43: error: incompatible type for argument 1 of '_mm256_cvtepi16_epi64'
__m256i x = _mm256_cvtepi16_epi64(_mm_loadu_si64(&x16[i]));
^~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/lib/gcc/x86_64-redhat-linux/8/include/immintrin.h:43,
from ../silk/x86/NSQ_del_dec_avx2.c:37:
/usr/lib/gcc/x86_64-redhat-linux/8/include/avx2intrin.h:468:32: note: expected '__m128i' {aka '__vector(2) long long int'} but argument is of type 'int'
_mm256_cvtepi16_epi64 (__m128i __X)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the Opus 1.5.2 build with GCC 8.5.0, then inspect silk/x86/NSQ_del_dec_avx2.c around line 959 and the AVX2 intrinsic headers involved. Confirm the build succeeds with GCC 8.5.0 without the reported _mm_loadu_si64 type error.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.