xiph / xiph/opus

opus_repacketizer_cat sometimes fails

Open
#328 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
3.3k
Forks
808
PR merge metrics
No merged PRs in 30d

Description

Hello. I found a behavior that seems to be a bug and I would like to report it.

opus_repacketizer_cat() sometimes failed with certain data.
Attached is a file for reproduction with the data.

bug.zip

> gcc bug.c -I./include -L./.libs -lopus -o bug.exe && ./bug.exe
[41] failed repacketizer corrupted stream(-4)

The following line caused opus_repacketizer_cat() to generate an error. it seemed to be a direct result of the TOC being different. I could not figure out why the TOC was changing.
image

I have confirmed reproduction with libopus1.4.
If I change from OPUS_APPLICATION_AUDIO to VOIP, the problem does not occur.
Sorry if I misunderstood something.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the attached bug.c reproduction and the gcc command, using libopus 1.4. Inspect the call to opus_repacketizer_cat() around the reported failing input and compare OPUS_APPLICATION_AUDIO with OPUS_APPLICATION_VOIP, including the differing TOC data. Done means the reproduction no longer fails or the behavior is documented as expected, with a regression test if the project has a suitable test location.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.