xiph / xiph/opus

Meson: Fail to build with clang-cl

Open
#288 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
3.3k
Forks
808
PR merge metrics
No merged PRs in 30d

Description

I'm trying to add Opus to Meson's WrapDB, but it fails the clang-cl CI:

FAILED: subprojects/opus-1.4/silk/libsilk_sse4_1.a.p/x86_NSQ_sse4_1.c.obj 
"clang-cl" "-Isubprojects\opus-1.4\silk\libsilk_sse4_1.a.p" "-Isubprojects\opus-1.4\silk" "-I..\subprojects\opus-1.4\silk" "-Isubprojects\opus-1.4" "-I..\subprojects\opus-1.4" "-Isubprojects\opus-1.4\include" "-I..\subprojects\opus-1.4\include" "-Isubprojects\opus-1.4\celt" "-I..\subprojects\opus-1.4\celt" "-I..\subprojects\opus-1.4\silk\float" "-I..\subprojects\opus-1.4\silk\fixed" "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W3" "/clang:-std=gnu99" "/Od" "/Zi" "-DOPUS_BUILD" "-DHAVE_CONFIG_H" "-D_CRT_SECURE_NO_WARNINGS" "/Fdsubprojects\opus-1.4\silk\libsilk_sse4_1.a.p\x86_NSQ_sse4_1.c.pdb" /Fosubprojects/opus-1.4/silk/libsilk_sse4_1.a.p/x86_NSQ_sse4_1.c.obj "/c" ../subprojects/opus-1.4/silk/x86/NSQ_sse4_1.c
../subprojects/opus-1.4/silk/x86/NSQ_sse4_1.c(345,22): error: always_inline function '_mm_shuffle_epi8' requires target feature 'ssse3', but would be inlined into function 'silk_noise_shape_quantizer_10_16_sse4_1' that is compiled without support for 'ssse3'
    a_Q12_01234567 = _mm_shuffle_epi8( a_Q12_01234567, xmm_one );
                     ^

https://github.com/mesonbuild/wrapdb/pull/1056

CC @tp-m

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with subprojects/opus-1.4/silk/x86/NSQ_sse4_1.c and the failing clang-cl command from WrapDB PR #1056. Reproduce the clang-cl CI failure and inspect how the build enables SIMD target features; done means the Opus WrapDB build completes successfully under clang-cl without the reported SSSE3 error.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.