Pkg-config file use difference Cflags convention to ogg/vorbis/flac
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 3.3k
- Forks
- 808
- PR merge metrics
- No merged PRs in 30d
Description
Other XIph libraries:
> grep ^Cflags /usr/lib/x86_64-linux-gnu/pkgconfig/ogg.pc
Cflags: -I${includedir}
> grep ^Cflags /usr/lib/x86_64-linux-gnu/pkgconfig/vorbis.pc
Cflags: -I${includedir}
> grep ^Cflags /usr/lib/x86_64-linux-gnu/pkgconfig/flac.pc
Cflags: -I${includedir}
Opus:
> grep ^Cflags /usr/lib/x86_64-linux-gnu/pkgconfig/opus.pc
Cflags: -I${includedir}/opus
Ogg/Vorbis/Flac then encourage the relevant header files to be included as:
#include <ogg/header.h>
#include <vorbis/header.h>
#include <FLAC/header.h>
which mitigates the possibility of header file names from one project clashing with another.
Please consider doing the same for Opus.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Opus pkg-config file or template that defines its Cflags, then compare it with the ogg, vorbis, and flac conventions shown in the issue. Done means the Opus flags and recommended header include convention avoid unqualified header-name collisions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- audio-video-rtc, build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100