xiph / xiph/flac

Feature wish: -A2, -A3 etc aliases for -A "subdivide_tukey(#)"

Open
#869 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
2.4k
Forks
363
PR merge metrics
No merged PRs in 30d

Description

Likely not highest priority, but likely not the biggest job when we get to 1.5.1 stage - mainly for those of us who do testing, but I wish I had asked this long ago before making a ton of typos over shell quotation marks.

  • Introduce the apodization functions "1", "2", "3" etc as "currently synonymous to subdivide_tukey(N)". (Suggesting "currently" like the presets: might change if someone comes up with something genius.)
  • That requires also to allow "subdivide_tukey(1)" as aliases to the standard tukey window.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named in the issue. Start by locating the command-line parsing and apodization handling for -A and subdivide_tukey, then inspect existing tests; done means numeric aliases and subdivide_tukey(1) behave as the specified Tukey-window equivalents.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.