xiph / xiph/flac

Add foreign metadata handling of some malformed chunks

Open
#680 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
2.4k
Forks
363
PR merge metrics
No merged PRs in 30d

Description

See https://hydrogenaud.io/index.php/topic,125651.0.html

Two issues here:

  • Protools creates files with padding at the end of the fmt chunk
  • Some tools create files containing chunks with an odd number of bytes

Handling of these files with --keep-foreign-metadata is currently limited or absent.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the code path handling --keep-foreign-metadata and read how fmt and other chunks are parsed. Use the linked discussion to understand the Protools padding and odd-byte cases; done means both malformed chunk forms are handled while preserving foreign metadata.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.