xiph / xiph/flac

Warnings reported by Infer

Open
#650 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
2.4k
Forks
363
PR merge metrics
No merged PRs in 30d

Description

  1. bug_type: UNINITIALIZED_VALUE, qualifier: The value read from has_real_points was never initialized., severity: ERROR, line: 2162, column: 5, procedure: convert_to_seek_table_template, procedure_start_line: 2128, file: flac/src/flac/encode.c
  2. bug_type: UNINITIALIZED_VALUE, qualifier: The value read from has_real_points was never initialized., severity: ERROR, line: 2167, column: 6, procedure: convert_to_seek_table_template, procedure_start_line: 2128, file: flac/src/flac/encode.c
  3. bug_type: DEAD_STORE, qualifier: The value written to &ok (type int) is never used., severity: ERROR, line: 38, column: 2, procedure: do_shorthand_operation__picture, procedure_start_line: 36, file: flac/src/metaflac/operations_shorthand_picture.c
  4. bug_type: DEAD_STORE, qualifier: The value written to &ok (type int) is never used., severity: ERROR, line: 38, column: 2, procedure: do_shorthand_operation__cuesheet, procedure_start_line: 36, file: flac/src/metaflac/operations_shorthand_cuesheet.c
  5. bug_type: DEAD_STORE, qualifier: The value written to &ok (type int) is never used., severity: ERROR, line: 35, column: 2, procedure: do_shorthand_operation__add_seekpoints, procedure_start_line: 33, file: flac/src/metaflac/operations_shorthand_seektable.c

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting flac/src/flac/encode.c at convert_to_seek_table_template and the three metaflac shorthand operation files at the reported lines. Run Infer on the affected code, trace the initialization and unused assignments, and consider the issue done when all five reported warnings are resolved without changing intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
backend, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.