xiph / xiph/flac

Zero-byte files left behind when trying to flac.exe out of subset

Open
#617 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

command-line tools enhancement/wish
Dominant language
C
Stars
2.4k
Forks
363
PR merge metrics
No merged PRs in 30d

Description

1.4.2 for Windows, the file is CDDA so that -b8192 is out of subset.

Scenario 1:
flac -fb8192 file.flac
Result: Leaves zero-byte .tmp,fl-ac+en'c . At least it tells me what file I failed at.

Scenario 2:
flac -t file.flac
flac -fb8192 file.wav
Result: Overwrites file.flac with a zero-byte file.

Expected: at least in the last scenario, it should throw error and do nothing at all?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing both scenarios with flac.exe using the commands in the issue, including the unsupported -b8192 setting. Then locate the Windows encoding path that creates temporary files and replaces the input, and verify that failed encoding leaves no zero-byte temporary or output files.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.