xch-dev / xch-dev/sage

Allow arbitrage in offers

Open
#281 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement offers
Dominant language
Rust
Stars
59
Forks
34
Avg merge
4d 14h
Merged PRs (30d)
31

Description

Currently requested payment amounts are selected from the wallet's existing coins. It would be ideal to exclude the offered amount from requested payments during coin selection, and essentially have the child pay for the parent. This allows aggregating two opposing offers for arbitrage.

It's unclear to me currently whether this also means refactoring offers again or if it's a simple change.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing wallet coin selection for requested payments and how offered amounts are represented in offers. Determine whether the offered amount can be excluded and whether child-pays-for-parent supports combining opposing offers; done means two opposing offers can be aggregated for arbitrage without double-counting coins.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
blockchain
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.