xbmc / xbmc/visualization.projectm

Please unlimit `preset_duration` to keep a selected visualization pattern forever or add a lock setting

Open Beginner friendly
#144 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
34
Forks
31
PR merge metrics
No merged PRs in 30d

Description

Why was preset_duration ever limited to a maximum?

https://github.com/xbmc/visualization.projectm/blob/a88737a3e978a5be41fe322febe56b6141d355f5/visualization.projectm/resources/settings.xml#L87

I am trying to make KODI playing a song with one selected visualization that I created and every 50 seconds its showing a white screen for a few seconds and then starts over again. Please make a preset last for as long as a user wants.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked settings.xml entry at line 87 and trace where preset_duration is read or enforced. Check how the visualization handles the selected preset and run the relevant Kodi visualization manually. Done means users can keep one selected preset active for an arbitrarily long duration without the white-screen reset, either through an unlimited duration or a lock setting.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.