xbmc / xbmc/visualization.projectm

framerate too high

Open
#141 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
34
Forks
31
PR merge metrics
No merged PRs in 30d

Description

I noticed that all presets seem to be running at twice the speed they should be. I believe this is linked to a variable in the source code being hard coded as 100fps:
https://github.com/xbmc/visualization.projectm/blob/054d47e98d56111f34c4c190729faf62c5eaf503/src/Main.h#L88

I am going through the process of cloning and building kodi and the addon to test if setting fps to 60 alleviates the issue but in the meantime, Would be great if this variable was editable in the addon settings.

EDIT: I successfully built the addon and here is what I have found:
version: Nexus
platform: windows 10 x64
Findings:

  • fps has no effect to the erratic high speed of the visuals
  • Commenting out all the code in CVisualizationProjectM::Render() (line 129) also has no effect!
    Seems like the projectM instance initialises but runs on random data within kodi, the output is not being controlled by either Render or AudioData

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/Main.h at line 88 and CVisualizationProjectM::Render() around line 129, then reproduce the Nexus build on Windows 10 x64. Check how the projectM instance is initialized and how audio data reaches it, since the report says changing FPS and commenting out Render() had no effect. Done means the visuals run at the intended speed and respond to Kodi's audio output.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.