xbmc / xbmc/inputstream.ffmpegdirect

build with "make" command fails in Fedora 43 for branch Omega

Open
#356 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
101
Forks
56
PR merge metrics
No merged PRs in 30d

Description

Commands used:

git clone --branch Omega https://github.com/xbmc/xbmc.git

git clone --branch Omega https://github.com/xbmc/inputstream.ffmpegdirect.git

cd inputstream.ffmpegdirect && mkdir build && cd build
cmake -DADDONS_TO_BUILD=inputstream.ffmpegdirect -DADDON_SRC_PREFIX=../.. -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=../../xbmc/build/addons -DPACKAGE_ZIP=1 ../../xbmc/cmake/addons

make

make command returns at the end:

libtool: warning: remember to run 'libtool --finish /home/vnm_rzv/inputstream.ffmpegdirect/build/build/depends/lib'
libtool: compile: gcc -I. -I. -I../include -I./../include -I.. -I./.. -g -O2 -fvisibility=hidden -DLIBDIR="/home/vnm_rzv/inputstream.ffmpegdirect/build/build/depends/lib" -DBUILDING_LIBICONV -DBUILDING_LIBCHARSET -DBUILDING_DLL -DENABLE_RELOCATABLE=1 -DIN_LIBRARY -DINSTALLDIR="/home/vnm_rzv/inputstream.ffmpegdirect/build/build/depends/lib" -DNO_XMALLOC -Dset_relocation_prefix=libiconv_set_relocation_prefix -Drelocate=libiconv_relocate -Drelocate2=libiconv_relocate2 -DHAVE_CONFIG_H -c ./iconv.c -fPIC -DPIC -o iconv.o
In file included from ./loops.h:23,
from ./iconv.c:148:
./loop_wchar.h:39:17: error: conflicting types for 'mbrtowc'; have 'size_t(void)' {aka 'long unsigned int(void)'}
39 | extern size_t mbrtowc ();
| ^~~~~~~
In file included from ../include/iconv.h:118,
from ./iconv.c:20:
/usr/include/wchar.h:321:15: note: previous declaration of 'mbrtowc' with type 'size_t(wchar_t * restrict, const char * restrict, size_t, mbstate_t * restrict)' {aka 'long unsigned int(int * restrict, const char * restrict, long unsigned int, mbstate_t * restrict)'}
321 | extern size_t mbrtowc (wchar_t *__restrict __pwc,
| ^~~~~~~
./loop_wchar.h: In function 'wchar_to_loop_convert':
./loop_wchar.h:356:15: error: too many arguments to function 'mbrtowc'; expected 0, have 4
356 | res = mbrtowc(&wc,buf,bufcount,&state);
| ^~~~~~~ ~~~
./loop_wchar.h:39:17: note: declared here
39 | extern size_t mbrtowc ();
| ^~~~~~~
make[7]: *** [Makefile:87: iconv.lo] Error 1
make[6]: *** [Makefile:33: all] Error 2
make[5]: *** [CMakeFiles/iconv.dir/build.make:86: iconv-prefix/src/iconv-stamp/iconv-build] Error 2
make[4]: *** [CMakeFiles/Makefile2:87: CMakeFiles/iconv.dir/all] Error 2
make[3]: *** [Makefile:136: all] Error 2
make[2]: *** [CMakeFiles/iconv.dir/build.make:86: build/iconv/src/iconv-stamp/iconv-build] Error 2
make[1]: *** [CMakeFiles/Makefile2:411: CMakeFiles/iconv.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the CMake add-on build command and the libiconv failure in loop_wchar.h, reached while compiling iconv.c. Read the surrounding build files and reproduce the make command on Fedora 43; done means the inputstream.ffmpegdirect build completes without the mbrtowc errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp, fedora
Domain
build-system, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.