xarray-contrib / xarray-contrib/xwrf

Remove dark-theme hack on next Xarray release

Open
#74 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
70
Forks
18
Avg merge
21m
Merged PRs (30d)
1

Description

What is your issue?

With the merging of https://github.com/pydata/xarray/pull/6501 and the closing of https://github.com/pydata/xarray/pull/6500, the hack for Xarray HTML reprs in the Furo Sphinx theme (implemented in #72) should no longer be needed. I don't believe that it will cause problems if it remains, but if it is no longer needed, I believe it should be removed.

The easiest way of satisfying this need is to simply remove the docs/_static/custom.js file and references to it in docs/conf.py.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting docs/_static/custom.js and its references in docs/conf.py, then check the related Xarray HTML repr changes described in PRs #6501 and #6500. Done means the obsolete dark-theme hack and its configuration references are removed without leaving broken documentation configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, python
Domain
documentation
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.