Don't set crs in attrs.

Open
#71 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
data

Research direction

Start by reviewing commit 2a7cf385c4623fcd5d41194bb6f9dd62800c0534 and the IndexSelResult handling. Trace scalar selection, where the index is dropped, and determine how CRS is currently duplicated between attrs and the index. Done means CRS is not duplicated while the scalar-selection edge case still preserves it in variable attrs when needed.

Written by the indexing model from the issue text.

Description

Currently the crs is duplicated in attrs and on the index.

The edge-case to handle is when you select with a scalar the index is dropped. In this case we may want to set it on the variable attrs in IndexSelResult.

This commit is a good starting point.

Dominant language
Python
Stars
139
Forks
14
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from xarray-contrib/xvec

All issues in xarray-contrib/xvec

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.