xarray-contrib / xarray-contrib/pint-xarray

comparing positive and negative angles in `degrees_east`

Open
#119 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

upstream changes
Dominant language
Python
Stars
119
Forks
15
PR merge metrics
No merged PRs in 30d

Description

from cf_xarray.units import units

220 * units.degrees_east == (-140 * units.degrees_east)

is False. Can this be True instead?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the Python example with cf_xarray.units.units and inspect how degrees_east comparisons are handled. Determine whether equivalent positive and negative angles should compare equal, then add a regression test for 220 and -140 degrees_east; done means the comparison returns True without breaking other unit comparisons.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.