Open source isn't Optional[X]
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 33.3k
- Forks
- 5.4k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 1
Description
Thanks for opening this up. One small thing: the Python half predates its own tooling. phoenix/ and bdsm/ both have a [tool.ruff] section, but it only sets line-length, so nothing is actually enforced. Under a normal ruff config that's 1,487 findings: 366 Optional[X], 231 typing.List/typing.Dict, 198 files with unsorted imports.
None of it changes what anyone's feed does. All of it changes how readable the code is, and for most people reading it, this repo is the reference.
I have a branch that adds a shared root ruff.toml, points the two existing configs at it, and applies the safe autofixes only: 246 files, +1304/−1280, everything byte-compiles, and the 403 findings that need human judgment are left alone. PR to follow if there's interest.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the existing [tool.ruff] sections in phoenix/ and bdsm/ and the proposed shared root ruff.toml. Run Ruff under the shared configuration and verify the safe autofixes across the 246 files; done means the code byte-compiles while the 403 findings requiring human judgment remain unresolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100