wuba / wuba/react-native-echarts
Skia is missing from renderer type
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 967
- Forks
- 35
- PR merge metrics
- No merged PRs in 30d
Description
I had to add my self the renderer type of skia inside echarts types
declare type RendererType = 'canvas' | 'svg' | 'skia';
Also maybe a good improvement is to consider using correct types and avoid any? For example these parts here.
const skiaRef = useRef<any>(null)
let chart: any
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ECharts RendererType declaration and the Skia-related component code containing skiaRef and chart. Review how existing renderer types and refs are typed before addressing the requested gaps. Done means Skia is represented in the renderer type and the identified any annotations have appropriate types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100