wuba / wuba/react-native-echarts

iOS svgChart default fontFamily setting

Open
#230 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
967
Forks
35
PR merge metrics
No merged PRs in 30d

Description

I noticed that in v2.0.0, the code converting sans-serif to Helvetica Neue was removed, but in v2.0.2 it was added back.
Image

I remembered that when I used v2.0.0 in November, even if I set the global textStyle in Echarts options, the error "unrecognized fontFamily" still occurred(it seemed like the setting did not apply to all the components of the chart, maybe the tooltip etc. ). Therefore I had to downgrade to v1.x.

It's nice to see that v2.0.2 works again, but I'm curious about the reason behind it. Could you explain?

P.s. Appreciate your contribution. This package really helps me a lot.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the iOS font handling between v2.0.0 and v2.0.2, focusing on the removed and restored sans-serif-to-Helvetica Neue conversion. Reproduce the unrecognized fontFamily error with a global ECharts textStyle, then document why the behavior changed and whether v2.0.2 applies the setting consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, react-native, typescript
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.