wso2 / wso2/api-platform

WebBrokerAPI: Fix: Avoid closing shared channels in WebBrokerApi closeConnection to prevent panics

Open
#1,960 0 comments 0 reactions 1 assignee View on GitHub

@senthuran16 is already working on this.

Since May 14, 2026.

Area/EventGateway
Dominant language
Go
Stars
71
Forks
111
Avg merge
1d 14h
Merged PRs (30d)
110

Description

Summary

In event-gateway/gateway-runtime/internal/connectors/receiver/websocket/broker_api_connector.go, the closeConnection method currently closes the conn.inbound and conn.outbound channels directly during teardown. This can cause panics when other goroutines (e.g., the broker consumer callback) are still attempting to send to these channels concurrently.

Problem

close(conn.inbound)
close(conn.outbound)

Since the broker callback goroutine may still be writing to conn.outbound after closeConnection is called, closing the channel here can result in a "send on closed channel" panic.

Proposed Fix

  • Remove the close(conn.inbound) and close(conn.outbound) calls from closeConnection.
  • Rely on context cancellation (already present via conn.cancel()) and consumer stop as the shutdown signal.
  • Ensure goroutines that own/read these channels are responsible for closing them when appropriate, after observing context cancellation.
  • Document that conn.outbound is not closed by teardown to avoid races with broker callback sends.

References

Requested by @senthuran16

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.