wpengine / wpengine/faustjs.org

bug: Combo box "searches" for selected result

Open
#342 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

accessibility bug
Dominant language
JavaScript
Stars
5
Forks
3
Avg merge
14h 35m
Merged PRs (30d)
2

Description

FAustjs search needs some work. We used a combobox that's designed to drive a select. Because of this your selected result is passed to "search" and we're manually doing a bunch of key handling and such that simple HTML should do.

Combobox can be replaced with a dialog.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the search UI that uses the combobox and trace how a selected result is passed into search. Confirm the current key-handling behavior, then replace the select-oriented combobox with a dialog while preserving search and selection behavior; the issue names no files or tests to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.