wp-media / wp-media/wp-rocket-e2e

Investigate failures in selfhostgooglefonts test templates

Open
#265 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1
Forks
1
Avg merge
3d 22h
Merged PRs (30d)
3

Description

Context
Starting with #264, we now have tests for the Self-host Google Fonts feature. A new expected-results JSON file was created for multiple font templates.

The last two templates in the list are currently disabled, because their expected results still show Google Fonts URLs pointing to the Google CDN. However, when checking those URLs manually, WP Rocket’s Self-host Google Fonts feature works correctly, and the fonts are hosted locally.

The 2 problematic page templates are:

Expected
All templates without an open issue in the /wp-rocket repo should be passing.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the selfhostgooglefonts test templates and their expected-results JSON, focusing on combine_GF_v2new.php and combine_GF_v3new.php. Compare the expected URLs with the template results and run the relevant E2E tests. Done means both templates pass with locally hosted fonts, unless an open wp-rocket issue explains the failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
playwright, typescript
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.